21 lines
1.3 KiB
Markdown
21 lines
1.3 KiB
Markdown
# Task 1 fix round 1 review package
|
|
|
|
Review only the two Important findings from the first Astra review.
|
|
|
|
## Files
|
|
|
|
- Current regression (changed): `D:/project/behind_glass/scripts/test-surface-reflection.mjs`
|
|
- Updated report (changed): `D:/project/behind_glass/docs/qa-surface-reflection/implementation-report.md`
|
|
- Production shader (unchanged during fix): `D:/project/behind_glass/src/shaders/mosaic.frag`
|
|
- Preserved baseline: `D:/project/behind_glass/docs/qa-surface-reflection/baseline-mosaic.frag`
|
|
- Original task brief: `D:/project/behind_glass/.superpowers/sdd/surface-reflection/task-1-brief.md`
|
|
|
|
## Fix evidence
|
|
|
|
- Production shader SHA-256 remains `5FB0AE93482AF46833B076EABFB0018E8BFEBA0A83BFD244DCD210371E450180`.
|
|
- Current test SHA-256: `B924F91C82D0805C23C292BE613B21B6253E73C17C45F78D54E0AFAF6BC94A54`.
|
|
- Command: `node scripts/test-surface-reflection.mjs`
|
|
- Output: `surface reflection source/math regression passed; constant-output mutation rejected`
|
|
|
|
The test now extracts complete individual statements, evaluates the actual `specGloss`, `broadReflection`, and final mix expression for representative inputs, compares refraction expressions to the preserved baseline, inspects the effective atlas branch, and asserts that a constant 50% white-output mutation is rejected.
|